Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better naming for CI jobs #2110

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Use better naming for CI jobs #2110

merged 8 commits into from
Jul 13, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 13, 2023 •
edited
Loading

Issue

Description

The CI jobs were sometimes messy (like Core / test_core (3.8)).

Related issues/PRs

N/A

Proposal

Explanation

Rename the CI jobs with better names (Core / Python 3.8).

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 13, 2023 13:00
danieljanes
danieljanes approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal enabled auto-merge (squash) July 13, 2023 14:41
@tanertopal tanertopal merged commit bf17b2b into main Jul 13, 2023
17 checks passed
@tanertopal tanertopal deleted the rename-ci-jobs branch July 13, 2023 14:57
tanertopal added a commit that referenced this pull request Jul 13, 2023
@tanertopal
Merge branch 'main' into improve_ci_speed
fc92f40 
* main:
  Use better naming for CI jobs (#2110)
  Update Opacus example to use latest version (#2112)
  Fix quickstart-fastai example (#2111)
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
@charlesbvll @danieljanes @alessiomora
Use better naming for CI jobs (adap#2110)
a513f63 
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes danieljanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @tanertopal @danieljanes