Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading levels in Examples #2136

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix heading levels in Examples #2136

merged 1 commit into from
Jul 18, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 18, 2023 •
edited
Loading

Issue

Description

The headers in the examples' README.md where sometimes incorrectly defined.

Related issues/PRs

#2133 depends on this PR

Proposal

Explanation

  • Only use H1 heading for the title of the document.
  • Use a name compatible with Sphinx for media folder (_static instead of media)

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@tanertopal tanertopal merged commit fbd15f9 into main Jul 18, 2023
@tanertopal tanertopal deleted the fix-examples branch July 18, 2023 12:34
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
@charlesbvll @alessiomora
Fix heading levels in Examples (adap#2136)
8521e42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @tanertopal