Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename examples using dash instead of underscore #2138

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Rename examples using dash instead of underscore #2138

merged 5 commits into from
Jul 19, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 18, 2023 •
edited
Loading

Issue

Description

We use underscore for the naming of the examples which is bad for URLs.

Related issues/PRs

#2133 depends on this.

Proposal

Explanation

Use dashes instead of underscores.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 18, 2023 14:45
danieljanes
danieljanes previously requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renaming itself looks good. We also need to change the references to those examples in READMEs and the docs.

@tanertopal tanertopal enabled auto-merge (squash) July 19, 2023 12:34
@tanertopal tanertopal dismissed danieljanes’s stale review July 19, 2023 13:47

Changes where made.

@tanertopal tanertopal merged commit f387950 into main Jul 19, 2023
18 checks passed
@tanertopal tanertopal deleted the rename-examples branch July 19, 2023 13:47
@charlesbvll charlesbvll mentioned this pull request Jul 19, 2023
Merged
3 tasks
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
@charlesbvll @alessiomora
Rename examples using dash instead of underscore (adap#2138)
bdab44b
@mariusschlegel mariusschlegel mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes left review comments

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @tanertopal @danieljanes