Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Secaggplus example #2183

Merged
merged 60 commits into from
Aug 24, 2023
Merged

Add Secaggplus example #2183

merged 60 commits into from
Aug 24, 2023

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Aug 2, 2023 •
edited
Loading

Issue

Description

We don't have an example for using the SecAgg+ protocol in Flower

Related issues/PRs

This PR is based on the following PR:
Add Secure Aggregation functionalities #2159

Proposal

Explanation

Add examples/secagg-mt-pytorch example

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

panh99 and others added 7 commits July 21, 2023 11:54
@panh99
Secaggplus (#2156)
6c9ed36 
* update validator.py & serde.py for SA

add serde functions

fix type checking errors

fix check errors

fix check err in serde.py

fix validation for TaskRes

* init

* init SA

* fix format

* fix mypy check errors

* add SA demo

* add unit tests for SA serde

* fix pylint errors

* ignore plint no-member error for numpy

* rename to secaggplus_utils.py

* fix bug in quantization, update secagg+ handler

* update secagg example

* update files from main

* update secaggplus

* fix a bug is type hint
@panh99 @danieljanes
Update src/py/flwr/client/secure_aggregation/__init__.py
80da399 
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
@danieljanes
Merge branch 'main' into secaggplus
78094c7
@panh99
rename and create consts
822ff6d
@panh99
reset serde.py to main
ee420b2
@panh99
remove secagg example
6bed121
@panh99
init example
62e2b54
panh99 and others added 21 commits August 2, 2023 23:32
@panh99
add readme for sa example
cfb57a6
@panh99
Merge branch 'main' into secaggplus
c068161
@panh99
Merge branch 'secaggplus' into secaggplus-example
b22ee04
@panh99
update name and re-format
89031cd
@panh99
fix invalid name error
b93bcc9
@panh99
Add unittests for secaggplus handler
8a2c079
@panh99
Merge branch 'main' into secaggplus
5224cc2
@panh99
Add content checks for SA messages
e25114a
@panh99
update unit tests for SA handler
8b15810
@panh99
Merge branch 'main' into secaggplus
2c3ec2d
@panh99
Merge branch 'secaggplus' into secaggplus-example
45ea7e2
@panh99
fix a bug causing exception in the collect masked input stage
bffd355
@panh99
format secagg-mt-pytorch
c4e2afd
@danieljanes
Add underscores to constants
7364f6f
@panh99
remove and update comments
9eeb6fd
@panh99 @danieljanes
Update src/py/flwr/client/secure_aggregation/secaggplus_handler_test.py
8ec786c 
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
@panh99 @danieljanes
Update src/py/flwr/client/secure_aggregation/secaggplus_handler.py
a26a1b9 
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
@panh99 @danieljanes
Update src/py/flwr/client/secure_aggregation/secaggplus_handler.py
b394eb8 
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
@panh99 @danieljanes
Update src/py/flwr/client/secure_aggregation/secaggplus_handler.py
004356d 
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
@panh99
update
13e5848
@panh99
Update comments
960303e
danieljanes
danieljanes requested changes Aug 24, 2023
View reviewed changes
examples/secaggplus-mt/client.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/client.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/client.py Show resolved Hide resolved
examples/secaggplus-mt/driver.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/settings.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/workflows.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/workflows.py Outdated Show resolved Hide resolved
examples/secaggplus-mt/workflows.py Outdated Show resolved Hide resolved
danieljanes
danieljanes previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danieljanes danieljanes enabled auto-merge (squash) August 24, 2023 09:17
@danieljanes danieljanes merged commit c1bbbe6 into main Aug 24, 2023
27 checks passed
@danieljanes danieljanes deleted the secaggplus-example branch August 24, 2023 09:53
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
@panh99 @alessiomora
Add Secaggplus example (adap#2183)
5765f8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @danieljanes