-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify client types #2390
Merged
Merged
Unify client types #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Oct 13, 2023
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
danieljanes
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
ClientLike
usage and therefore everywhere a client object of typeClient
is expected. For this, the idea is that users will call<their_client>.to_client()
when returning inside theirClientFn
.to_client()
is a new method that bothClient
andNumPyClient
have.For backwards compatibility:
start_numpy_client
when users supply a client object (that should be of typeClientNumPy
). In this case,.to_client()
is called internally and transparently to the user. However a Deprecation warning is triggered encouraging users to usestart_client
instead.client_fn
is not of typeClient
. Then, the client is converted toClient
type.In addition this PR:
numpy_client_wrapper.py
has been moved toclient.py
(where it used to be not long ago)Part of the content above was done in #2493.