-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FedVSSL baseline #2412
Add FedVSSL baseline #2412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I was able to run the experiments fine. Interestingly i got much better results for UCF-101 results when pretraining on UCF-101 than those in the table...
Could you take some time to address the comments below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yasar-rehman , @yan-gao-GY ,
This baseline can be merged 🥳 . But first, could you look at the comment i left below? Ping me when ready.
In the Expected Results
section it says "takes a considerable amount of time without access to server-grade hardware (~5 days with a RTX 3090)". But i thought you'd need several RTX 3090? is it 6 of them as stated earlier in the README.md
?
@jafermarq thanks for your recent fix! It would take ~1 day if using 6 RTX 3090. Let's change the statement in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your FedVSSL
baseline is ready to be merged. Many thanks for thanks for the hard work !
Issue
#2058
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions
)Any other comments?