Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let start_simulation crash if flag is set. #2447

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Let start_simulation crash if flag is set. #2447

merged 6 commits into from
Oct 10, 2023

Conversation

jafermarq
Copy link
Contributor

In some settings we might want to let simulation's app.py to throw an exception. This is useful for instance if some action needs to be taken when this happens.

@jafermarq jafermarq marked this pull request as ready for review October 2, 2023 21:19
@danieljanes danieljanes marked this pull request as draft October 7, 2023 12:38
@danieljanes
Copy link
Member

@jafermarq converted to draft as there are merge conflicts

@jafermarq jafermarq marked this pull request as ready for review October 9, 2023 10:13
@danieljanes danieljanes enabled auto-merge (squash) October 10, 2023 12:20
@danieljanes danieljanes merged commit fb02063 into main Oct 10, 2023
26 checks passed
@danieljanes danieljanes deleted the let-vce-crash branch October 10, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants