Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sklearn data preparation to use Flower Datasets #2450

Merged
merged 10 commits into from
Dec 18, 2023

Conversation

adam-narozniak
Copy link
Member

Issue

Scikit Learn example used custom download - openml and by-hand partitioning, which makes the example harder to follow.

Proposal

  • Change openml and custom partitioning to Flower Datasets
  • Add partition index specification via the command line (instead of choosing a random number)
  • Fix data types (type hinting)

jafermarq
jafermarq previously approved these changes Dec 15, 2023
@jafermarq jafermarq enabled auto-merge (squash) December 15, 2023 18:15
@tanertopal tanertopal enabled auto-merge (squash) December 17, 2023 14:37
tanertopal
tanertopal previously approved these changes Dec 17, 2023
@jafermarq jafermarq dismissed stale reviews from tanertopal and themself via 10899f2 December 18, 2023 19:48
@tanertopal tanertopal merged commit 0eec9e5 into main Dec 18, 2023
27 checks passed
@tanertopal tanertopal deleted the fds-migrate-sklearn-log-reg-mnist branch December 18, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants