Add Driver class
#2531
Merged
Add Driver class
#2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Oct 21, 2023
danieljanes
requested changes
Oct 24, 2023
src/py/flwr/driver/driver.py
Outdated
| ) | ||
| return list(res.nodes) | ||
|
|
||
| def push_task_ins(self, task_ins_list: Iterable[TaskIns]) -> List[str]: |
There was a problem hiding this comment.
Let's use List here to be consistent with the argument name (we can generalize to Iterable later):
Suggested change
| def push_task_ins(self, task_ins_list: Iterable[TaskIns]) -> List[str]: | |
| def push_task_ins(self, task_ins_list: List[TaskIns]) -> List[str]: |
src/py/flwr/driver/driver.py
Outdated
Comment on lines
187
to
189
| # Check if task_ids is None | ||
| if task_ids is None: | ||
| task_ids = list(self.task_id_pool) |
There was a problem hiding this comment.
Let's remove this utility for now, and leave it up to the user to keep track of task_ids.
danieljanes
requested changes
Oct 24, 2023
danieljanes
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Driverclass indriver/driver.py.Add unit tests for
Driverindriver/driver_test.py