Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tasks validation to C++ SDK #2543

Merged
merged 15 commits into from
Nov 6, 2023
Merged

Add Tasks validation to C++ SDK #2543

merged 15 commits into from
Nov 6, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Oct 30, 2023

Issue

Description

On the C++ SDK we currently don't validate task messages, that can lead to unexpected behavior.

Related issues/PRs

N/A

Proposal

Explanation

Add validate_task_ins and and validate_task_res functions.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review October 30, 2023 10:11
@danieljanes danieljanes enabled auto-merge (squash) November 6, 2023 16:11
@danieljanes danieljanes merged commit 2800482 into main Nov 6, 2023
27 checks passed
@danieljanes danieljanes deleted the add-rere-validation branch November 6, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants