Create docker base images #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
force-pushed
the
docker-base-image
branch
11 times, most recently
from
ff52b47
to
aa26838
Compare
Robert-Steiner
force-pushed
the
docker-base-image
branch
2 times, most recently
from
f75190b
to
a3491af
Compare
Robert-Steiner
requested review from
danieljanes and
tanertopal
as code owners
Robert-Steiner
force-pushed
the
docker-base-image
branch
2 times, most recently
from
67e7d72
to
7e2521b
Compare
tanertopal
reviewed
Dec 6, 2023
.github/workflows/docker-server.yml
Outdated
| secrets: | ||
| dockerhub-user: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| dockerhub-token: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
|
||
| summary: | ||
| runs-on: ubuntu-22.04 | ||
| needs: build-server-images | ||
| timeout-minutes: 5 |
There was a problem hiding this comment.
@Robert-Steiner Should we increase this to 10min to give a bit more time in case the CI is slow due to e.g. bad network speed? I believe 10min is still acceptable for these jobs. Feel free to keep it at 5 if you think it's reasonable.
There was a problem hiding this comment.
I think we can increase it to 10 to be on the safe side.
Robert-Steiner
force-pushed
the
docker-base-image
branch
from
7e2521b
to
684ee32
Compare
tanertopal
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Building the server images for non-native platforms (e.g. arm) can take a long time because they run in an emulator. Most of the time is spent installing/compiling python. We want to keep our release CI fast therefore we need to find a way to speed it up.
A python version change will occur less frequently than releasing a new Flower version. The idea is to move this installation to a base image and use that image later when building the server image. This should reduce the build time of the server images. The base image can also be used later for the client images.
Description
This PR moves the installation of system dependencies, python and general python dependencies into its own Dockerfile. This change significantly reduces the build time of the server images. Building the a server images takes now 2 minutes. I restructured the reusable workflow code so that it can be used to build the base and server image.