Add dockerfile for flower client image #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
requested review from
danieljanes and
tanertopal
as code owners
Robert-Steiner
commented
Dec 21, 2023
src/docker/client/Dockerfile
Outdated
| FROM $BASE_REPOSITORY:$BASE_IMAGE_TAG | ||
|
|
||
| ARG FLWR_VERSION | ||
| RUN python -m pip install -U --no-cache-dir flwr"[rest, simulation]"==${FLWR_VERSION} |
There was a problem hiding this comment.
@tanertopal I'm unsure, if we need the simulation feature
There was a problem hiding this comment.
@danieljanes @jafermarq Not sure either. Do we need "simulation"
in the client image? I would assume no but please correct me if I am wrong.
tanertopal
approved these changes
Jan 3, 2024
mohammadnaseri
added a commit
that referenced
this pull request
Jan 9, 2024
Fix the static method error --------- Co-authored-by: Daniel J. Beutel <daniel@flower.dev> Co-authored-by: Robert Steiner <robert@flower.dev> Update types-requests requirement from ==2.31.0.2 to ==2.31.0.10 (#2739) Updates the requirements on [types-requests](https://github.com/python/typeshed) to permit the latest version. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taner Topal <taner@flower.dev> Make the optional arg "--callable" in `flower-client` a required positional arg. (#2673) Co-authored-by: Javier <jafermarq@users.noreply.github.com> Update jupyterlab requirement from ==4.0.8 to ==4.0.9 (#2740) Updates the requirements on [jupyterlab](https://github.com/jupyterlab/jupyterlab) to permit the latest version. - [Release notes](https://github.com/jupyterlab/jupyterlab/releases) - [Changelog](https://github.com/jupyterlab/jupyterlab/blob/@jupyterlab/lsp@4.0.9/CHANGELOG.md) - [Commits](https://github.com/jupyterlab/jupyterlab/compare/@jupyterlab/lsp@4.0.8...@jupyterlab/lsp@4.0.9) --- updated-dependencies: - dependency-name: jupyterlab dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taner Topal <taner@flower.dev> HeteroFL baseline (#2439) Co-authored-by: jafermarq <javier@flower.dev> Retire `MXNet` examples (#2724) Co-authored-by: Taner Topal <taner@flower.dev> Rename draft release workflow and create release (#2658) Update Android manifest to include internet permission (#2672) Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 (#2756) Bumps [lewagon/wait-on-check-action](https://github.com/lewagon/wait-on-check-action) from 1.3.1 to 1.3.3. - [Release notes](https://github.com/lewagon/wait-on-check-action/releases) - [Commits](lewagon/wait-on-check-action@v1.3.1...v1.3.3) --- updated-dependencies: - dependency-name: lewagon/wait-on-check-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update ruff requirement from ==0.1.4 to ==0.1.9 (#2753) Updates the requirements on [ruff](https://github.com/astral-sh/ruff) to permit the latest version. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.1.4...v0.1.9) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel J. Beutel <daniel@flower.dev> Add FedAvgM baseline (#2246) Co-authored-by: Daniel J. Beutel <daniel@adap.com> Co-authored-by: jafermarq <javier@flower.dev> Add dockerfile for flower client image (#2746) Add docker client image ci (#2747) Rename `workload_id` to `run_id` (#2769) Update README.md (#2771) Format code examples (#2767) Rename WorkloadState to RunState (#2770) Add in-place FedAvg (#2293) Update the error message when simulation crashes (#2759) Add tests Add tests Fix tests Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We currently offer docker images for our server but not for our client. In order to make developing with Flower as easy as possible, we want to close this gap.
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?