Make communications pluggable in C++ SDK #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o cpp-better-comms
danieljanes
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The C++ SDK can currently only be used with a gRPC communication channel, this can be limiting for custom communication stacks.
Related issues/PRs
N/A
Proposal
Explanation
In this PR, we make the communication related code separate from the main client logic by creating a new abstract class
Communicatorand a gRPC implementation of it.Checklist
#contributions)Changelog entry
In the C++ SDK, the communication related code is now separate from the main client logic. A new abstract class
Communicatorhas been introduced along side a gRPC implementation of it.Any other comments?
N/A