Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST transport to client callable #2879

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Add REST transport to client callable #2879

merged 5 commits into from
Jan 31, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

The current client callable cannot instantiate REST clients.

Related issues/PRs

N/A

Proposal

Explanation

Add a new argument to the callable that instantiates a REST client. Also adds new E2E tests for REST clients.

Checklist

  • Implement proposed change
  • Write tests
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

N/A

@danieljanes danieljanes merged commit e49a0c9 into main Jan 31, 2024
27 checks passed
@danieljanes danieljanes deleted the add-rest-client branch January 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants