Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework:cli) Add HuggingFace template for flwr new #3284

Merged
merged 14 commits into from
May 8, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

We have no template for HuggingFace when using flwr new.

Related issues/PRs

N/A

Proposal

Explanation

Add a new template that create a HuggingFace project.

Checklist

  • Implement proposed change
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review April 22, 2024 10:01
@charlesbvll charlesbvll changed the title feat(cli): add HuggingFace template for flwr new feat(framework:cli): Add HuggingFace template for flwr new Apr 23, 2024
adam-narozniak
adam-narozniak previously approved these changes Apr 29, 2024
Copy link
Member

@adam-narozniak adam-narozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charlesbvll charlesbvll changed the title feat(framework:cli): Add HuggingFace template for flwr new feat(framework:cli) Add HuggingFace template for flwr new May 7, 2024
@danieljanes danieljanes merged commit 173ee6b into main May 8, 2024
28 checks passed
@danieljanes danieljanes deleted the add-hf-template branch May 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants