Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nightly) wait 30 min before building nightly images #3294

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Apr 19, 2024

Issue

Description

The current wait-on-pypi solution didn't work out that well. I guess that uploads on PyPI are eventually consistent.

To give PyPI a bit more time, the release of the docker images will be triggered 30 min after the package has been published.

I defined multiple schedule events to implement that behavior as shown here.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

Signed-off-by: Robert Steiner <robert@flower.ai>
@tanertopal tanertopal enabled auto-merge (squash) April 23, 2024 11:22
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 92185c9 into main Apr 23, 2024
27 checks passed
@tanertopal tanertopal deleted the fix/docker-nightly-2 branch April 23, 2024 11:29
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: Robert Steiner <robert@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants