Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*:skip) Improve automated changelog generation #3356

Merged
merged 45 commits into from
Nov 21, 2024

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Apr 29, 2024

Issue

Description

Our changelog generation script didn't work automatically with our new PR title format.

Related issues/PRs

N/A

Proposal

Explanation

Use the PR title to categorise the PRs.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll changed the title feat(framework:scripts): Improve automated changelog generation feat(framework) Improve automated changelog generation May 16, 2024
@charlesbvll charlesbvll changed the title feat(framework) Improve automated changelog generation ci(*:skip) Improve automated changelog generation May 28, 2024
@charlesbvll charlesbvll marked this pull request as ready for review June 11, 2024 08:10
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of moving update_changelog to dev, it would be better to keep it in flwr_tool and eventually move flwr_tool into a separate project

@charlesbvll
Copy link
Member Author

Instead of moving update_changelog to dev, it would be better to keep it in flwr_tool and eventually move flwr_tool into a separate project

Shouldn't this be done in a separate PR? I feel like in terms of consistency, it makes more sense to have everything under dev/ (as flwr_tool currently only contains the protoc.py script, whereas dev/ contains all dev scripts similar to the update_changelog.py script)

dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
dev/update_changelog.py Outdated Show resolved Hide resolved
@danieljanes danieljanes merged commit 81ae839 into main Nov 21, 2024
56 checks passed
@danieljanes danieljanes deleted the improve-changelog-generation branch November 21, 2024 16:46
flydump pushed a commit to flydump/flower that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants