Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(supernode-docker) Add Docker SuperNode documentation #3371

Merged
merged 7 commits into from
May 2, 2024
Merged

docs(supernode-docker) Add Docker SuperNode documentation #3371

merged 7 commits into from
May 2, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Apr 30, 2024 •
edited
Loading

Issue

Description

Document how to build and run a SuperNode Docker image.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@Robert-Steiner
docs(supernode-docker) Add Docker SuperNode sesction
3ccbc4d 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner changed the title docs(supernode-docker) Add Docker SuperNode sesction docs(supernode-docker) Add Docker SuperNode section May 2, 2024
@Robert-Steiner
Copy client code instead of mounting it
f6ab87f 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner changed the title docs(supernode-docker) Add Docker SuperNode section docs(supernode-docker) Add Docker SuperNode documentation May 2, 2024
@Robert-Steiner Robert-Steiner marked this pull request as ready for review May 2, 2024 12:10
Robert-Steiner and others added 3 commits May 2, 2024 14:41
@Robert-Steiner @danieljanes
Apply suggestions from code review
04b8e37 
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@Robert-Steiner
rm insecure flag
b6c2dde 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner
add note about the status
3c64213 
Signed-off-by: Robert Steiner <robert@flower.ai>
@danieljanes danieljanes enabled auto-merge (squash) May 2, 2024 13:12
@danieljanes danieljanes merged commit ccb841e into main May 2, 2024
28 checks passed
@danieljanes danieljanes deleted the doc/supernode-docker-docs branch May 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robert-Steiner @danieljanes