Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Log a warning if the server fails to get initial parameters #3461

Merged
merged 5 commits into from
May 19, 2024
Merged

feat(framework) Log a warning if the server fails to get initial parameters #3461

merged 5 commits into from
May 19, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented May 16, 2024 •
edited
Loading

Problem

Currently, in both server.py and default_workflows.py, the server side will not log anything when it fails to get initial parameters from Strategy and Client, and will proceed with empty parameters.

Solution

After a few rounds of discussion with @jafermarq , we think this is one of the cleanest solution to fix the issue.

Check the status code of the GetParametersRes. Log a warning if the status code is not Code.OK.

jafermarq
jafermarq previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. You'll need to update the title of the PR to follow the format in here #3452 . I guess the below would do:

feat(framework) Log a warning if the server fails to get initial parameters.

@panh99 panh99 changed the title Log a warning if the server fails to get initial parameters feat(framework) Log a warning if the server fails to get initial parameters. May 16, 2024
@panh99 panh99 changed the title feat(framework) Log a warning if the server fails to get initial parameters. feat(framework) Log a warning if the server fails to get initial parameters May 16, 2024
danieljanes
danieljanes previously approved these changes May 19, 2024
View reviewed changes
@jafermarq jafermarq dismissed stale reviews from danieljanes and themself via 6510f26 May 19, 2024 08:46
@danieljanes danieljanes enabled auto-merge (squash) May 19, 2024 15:46
@danieljanes danieljanes merged commit 938b087 into main May 19, 2024
29 checks passed
@danieljanes danieljanes deleted the fix-get-params branch May 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq jafermarq left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq