ci(framework:skip) Switch to new base images #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
changed the title
Robert-Steiner
force-pushed
the
chore/switch-binary-images
branch
from
8df7ded
to
0fb6ca4
Compare
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
force-pushed
the
chore/switch-binary-images
branch
from
0fb6ca4
to
0eadfd6
Compare
Moep90
previously approved these changes
May 23, 2024
tanertopal
reviewed
May 23, 2024
dev/build-docker-image-matrix.py
Outdated
Comment on lines
173
to
201
| # { | ||
| # "base": { | ||
| # "images": [ | ||
| # { | ||
| # "distro": { | ||
| # "name": "ubuntu", | ||
| # "version": "22.04" | ||
| # }, | ||
| # "python_version": "3.8", | ||
| # "namespace_repository": "flwr/base", | ||
| # "file_dir": "src/docker/base/ubuntu", | ||
| # "tag": "1.8.0-py3.8-ubuntu22.04", | ||
| # "flwr_version": "1.8.0" | ||
| # }, | ||
| # ... | ||
| # ] | ||
| # }, | ||
| # "binary": { | ||
| # "images": [ | ||
| # { | ||
| # "namespace_repository": "flwr/superlink", | ||
| # "file_dir": "src/docker/superlink", | ||
| # "base_image": "1.8.0-py3.11-alpine3.19", | ||
| # "tags": "1.8.0-py3.11-alpine3.19\n1.8.0" | ||
| # }, | ||
| # ... | ||
| # ] | ||
| # } | ||
| # } |
There was a problem hiding this comment.
Do we still need this here?
There was a problem hiding this comment.
I don't think so. We can remove it
Signed-off-by: Robert Steiner <robert@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
tags.pulltotrueto ensure that always the latest pushed image is pulled.Builds the following images:
Base
SuperLink
SuperNode
ServerApp
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?