-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework) Add initial SuperExec
service
#3555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
reviewed
Jun 13, 2024
danieljanes
reviewed
Jun 13, 2024
danieljanes
reviewed
Jun 13, 2024
danieljanes
reviewed
Jun 13, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The
SuperExec
service will be responsible of receivingStartRun
requests from theflwr run
CLI, passing this request to a givenExecutor
plugin, and returning the response to theflwr run
CLI.Related issues/PRs
N/A
Proposal
Explanation
src/py/flwr/superexec
with a dummy testExecutor
intest_executor.py
.flwr run
command to accept a--use-superexec
argument to be able to test the service.Checklist
#contributions
)Any other comments?
N/A