Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples) Add Tabular Dataset Example #3568

Merged
merged 26 commits into from
Jun 20, 2024
Merged

Conversation

mohammadnaseri
Copy link
Contributor

@mohammadnaseri mohammadnaseri commented Jun 10, 2024

This PR introduces a new example about the use of the Adult Census Income Tabular dataset in Flower.

Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mohammadnaseri , i left a few comments below. In addition, I see quite a few warnings in the form of:

DeprecationWarning: np.find_common_type is deprecated.  Please use `np.result_type` or `np.promote_types`.

It would be good to find the line causing it (maybe the .select_dtypes?)

examples/fl-tabular/centralized.py Outdated Show resolved Hide resolved
examples/fl-tabular/pyproject.toml Outdated Show resolved Hide resolved
examples/fl-tabular/federated.py Outdated Show resolved Hide resolved
examples/fl-tabular/federated.py Outdated Show resolved Hide resolved
examples/fl-tabular/README.md Outdated Show resolved Hide resolved
examples/fl-tabular/centralized.py Outdated Show resolved Hide resolved
examples/fl-tabular/centralized.py Outdated Show resolved Hide resolved
examples/fl-tabular/federated.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some extra comments. We should also list the example in the top-level README.md

examples/fl-tabular/README.md Outdated Show resolved Hide resolved
examples/fl-tabular/README.md Outdated Show resolved Hide resolved
examples/fl-tabular/task.py Outdated Show resolved Hide resolved
examples/fl-tabular/task.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jafermarq jafermarq enabled auto-merge (squash) June 20, 2024 11:20
@jafermarq jafermarq merged commit 2ede647 into main Jun 20, 2024
29 checks passed
@jafermarq jafermarq deleted the add-tabular-dataset-example branch June 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants