Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework:skip) Add Flower File Storage interface and disk based implementation #3619

Merged
merged 27 commits into from
Aug 12, 2024
Merged

feat(framework:skip) Add Flower File Storage interface and disk based implementation #3619

merged 27 commits into from
Aug 12, 2024

Conversation

tanertopal
Copy link
Member

@tanertopal tanertopal commented Jun 16, 2024 •
edited
Loading

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@tanertopal
feat(framework:skip) Add Flower File Storage interface and disk based…
8f4d7c2 
… implementation
@tanertopal
Merge branch 'add_first_ffs_impl' of github.com:adap/flower into add_…
b06d6cd 
…first_ffs_impl

* 'add_first_ffs_impl' of github.com:adap/flower:
  feat(framework:skip) Add Flower File Storage interface and disk based implementation
@tanertopal
Fix type errors
5f57946
charlesbvll
charlesbvll previously approved these changes Aug 7, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) August 12, 2024 20:46
@danieljanes danieljanes merged commit 01896eb into main Aug 12, 2024
33 checks passed
@danieljanes danieljanes deleted the add_first_ffs_impl branch August 12, 2024 20:50
chongshenng pushed a commit that referenced this pull request Aug 13, 2024
@tanertopal @danieljanes
@charlesbvll @chongshenng
feat(framework:skip) Add Flower File Storage interface and disk based…
27a34c9 
… implementation (#3619)

Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Charles Beauville <charles@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbvll charlesbvll charlesbvll left review comments

@danieljanes danieljanes danieljanes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanertopal @danieljanes @charlesbvll