Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add override config to SuperExec #3731

Merged
merged 6 commits into from
Jul 8, 2024
Merged

feat(framework) Add override config to SuperExec #3731

merged 6 commits into from
Jul 8, 2024

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 7, 2024 •
edited
Loading

Issue

Description

We need the SuperExec to pass the override_dict to the ServerApp.

Related issues/PRs

The current PR is blocked by #3728

Proposal

Explanation

We need to modify the Servicer to return the override_config dict from the gRPC response and modify the start_run function of the Executor abstract class to accept it as a new parameter.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll mentioned this pull request Jul 7, 2024
Merged
3 tasks
@charlesbvll charlesbvll marked this pull request as ready for review July 8, 2024 12:32
@danieljanes danieljanes merged commit b735710 into main Jul 8, 2024
29 checks passed
@danieljanes danieljanes deleted the add-override-config-superexec branch July 8, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @danieljanes