fix(framework:skip) Pass arguments to run the ServerApp explicitly
#3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
changed the title
ServerApp explicitly
danieljanes
approved these changes
Jul 11, 2024
danieljanes
deleted the
explicit-passing-of-arguments-to-serverapp-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Simulation Engine was passing
kwargsto run_serverapp.run() in a way that was able to circumvent the tests. This resulted in issues to not be automatically detectable.Now, arguments passed to
run_serverapp.run()need to be passed one by one.This PR also introduces the new
server_app_run_configdictionary.