Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*:skip) Update client_fn args in e2e tests #3775

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

client_fn(cid) is deprecated, we need to update e2e tests to use latest args.

Related issues/PRs

Proposal

Explanation

Update e2e tests to use latest args.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danieljanes danieljanes marked this pull request as draft July 11, 2024 14:53
danieljanes
danieljanes previously approved these changes Jul 13, 2024
@danieljanes danieljanes marked this pull request as ready for review July 13, 2024 14:25
@danieljanes danieljanes merged commit 5505e0a into main Jul 13, 2024
28 checks passed
@danieljanes danieljanes deleted the update-client-args-e2e branch July 13, 2024 14:29
chongshenng pushed a commit that referenced this pull request Jul 16, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants