Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework:skip) Remove dependency installation from SuperExec #3781

Merged
merged 3 commits into from
Jul 14, 2024

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 12, 2024

Issue

Description

On the SuperExec we currently install the dependencies associated with a given Flower App. This can create situations where conflicting version of flwr can be installed.

Related issues/PRs

N/A

Proposal

Explanation

Use the --no-deps pip flag when installing the Flower App.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 12, 2024 10:56
@danieljanes danieljanes enabled auto-merge (squash) July 14, 2024 12:44
@danieljanes danieljanes merged commit 52597bd into main Jul 14, 2024
28 checks passed
@danieljanes danieljanes deleted the remove-deps-superexec branch July 14, 2024 12:49
chongshenng pushed a commit that referenced this pull request Jul 16, 2024
)

Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants