Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add node-config arg to SuperNode #3782

Merged
merged 15 commits into from
Jul 12, 2024
Merged

feat(framework) Add node-config arg to SuperNode #3782

merged 15 commits into from
Jul 12, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll changed the title feat(framework:skip) Add node-config arg to SuperNode feat(framework) Add node-config arg to SuperNode Jul 12, 2024
danieljanes
danieljanes previously approved these changes Jul 12, 2024
View reviewed changes
@jafermarq jafermarq marked this pull request as ready for review July 12, 2024 16:21
@jafermarq jafermarq enabled auto-merge (squash) July 12, 2024 16:23
@jafermarq jafermarq merged commit ea8f940 into main Jul 12, 2024
28 checks passed
@jafermarq jafermarq deleted the add-node-config-cli-arg branch July 12, 2024 16:26
chongshenng pushed a commit that referenced this pull request Jul 16, 2024
@charlesbvll @jafermarq
@danieljanes @chongshenng
feat(framework) Add node-config arg to SuperNode (#3782)
596f859 
Co-authored-by: jafermarq <javier@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @danieljanes @jafermarq