Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Update subprocess launch mechanism for simulation plugin #3826

Merged
merged 7 commits into from
Jul 17, 2024
Merged

feat(framework) Update subprocess launch mechanism for simulation plugin #3826

merged 7 commits into from
Jul 17, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jul 17, 2024 •
edited
Loading

Replaces subprocess.Popen with subprocess.run for SuperExec's simulation plugin.

@jafermarq jafermarq changed the title feat(framework) temp-logs-in-superexec feat(framework) Make temp fix in superexec logs Jul 17, 2024
@jafermarq jafermarq changed the title feat(framework) Make temp fix in superexec logs feat(framework) Update subprocess launch mechanism for simulation plugin Jul 17, 2024
@jafermarq jafermarq marked this pull request as ready for review July 17, 2024 16:48
@jafermarq jafermarq requested a review from Moep90 July 17, 2024 16:49
@danieljanes danieljanes merged commit a20e4c9 into main Jul 17, 2024
30 checks passed
@danieljanes danieljanes deleted the temp-logs-in-superexec branch July 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@Moep90 Moep90 Awaiting requested review from Moep90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafermarq @danieljanes @Moep90