Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(framework) Fix quickstart comments #3920

Merged
merged 1 commit into from
Jul 26, 2024
Merged

docs(framework) Fix quickstart comments #3920

merged 1 commit into from
Jul 26, 2024

Conversation

yanmxa
Copy link
Contributor

@yanmxa yanmxa commented Jul 26, 2024

Description

Correct the description of the sample document of the client

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

@yanmxa
Correct the document
7749a93 
Signed-off-by: myan <myan@redhat.com>
danieljanes
danieljanes approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @yanmxa !

@danieljanes danieljanes enabled auto-merge (squash) July 26, 2024 06:53
@danieljanes danieljanes changed the title Correct the sample document docs(framework) Fix quickstart comments Jul 26, 2024
@danieljanes danieljanes merged commit af6d8dd into adap:main Jul 26, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanmxa @danieljanes