feat(framework) Add template to create a Flower Baseline #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
changed the title
tanertopal
reviewed
Aug 26, 2024
tanertopal
reviewed
Aug 26, 2024
Co-authored-by: Taner Topal <taner@flower.dev>
danieljanes
reviewed
Aug 27, 2024
danieljanes
reviewed
Aug 27, 2024
danieljanes
reviewed
Aug 27, 2024
danieljanes
reviewed
Aug 27, 2024
Comment on lines
35
to
40
| line_length = 88 | ||
| indent = " " | ||
| multi_line_output = 3 | ||
| include_trailing_comma = true | ||
| force_grid_wrap = 0 | ||
| use_parentheses = true |
There was a problem hiding this comment.
Isn't there a newer version of this where isort supports a black profile?
danieljanes
reviewed
Aug 27, 2024
Comment on lines
+124
to
+142
| [tool.flwr.app] | ||
| publisher = "$username" | ||
|
|
||
| [tool.flwr.app.components] | ||
| serverapp = "$import_name.server_app:app" | ||
| clientapp = "$import_name.client_app:app" | ||
|
|
||
| [tool.flwr.app.config] | ||
| num-server-rounds = 3 | ||
| fraction-fit = 0.5 | ||
| local-epochs = 1 | ||
|
|
||
| [tool.flwr.federations] | ||
| default = "local-simulation" | ||
|
|
||
| [tool.flwr.federations.local-simulation] | ||
| options.num-supernodes = 10 | ||
| options.backend.client-resources.num-cpus = 2 | ||
| options.backend.client-resources.num-gpus = 0.0 |
There was a problem hiding this comment.
Should we perhaps move tool.flwr ahead of all the other configs (the ones we expect users not to edit)?
There was a problem hiding this comment.
I thought of keeping it as in the rest of templates and (migrated) examples
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
reviewed
Aug 28, 2024
danieljanes
reviewed
Aug 28, 2024
danieljanes
reviewed
Aug 28, 2024
danieljanes
reviewed
Aug 28, 2024
src/py/flwr/cli/new/templates/app/code/strategy.baseline.py.tpl
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Aug 28, 2024
danieljanes
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds template creation logic for a new Flower Baseline.
It reutilises components from the
PoTorchtemplate. It will generate the following directory structure: