fix(framework) Pin gRPC version to ^1.60.0,!=1.64.2,<=1.64.3
#4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongshenng
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Lgtm and I think this is unavoidable for now until we fix the CI. In the meantime, let's debug with the latest grpcio version in another branch. Wdyt @danieljanes?
danieljanes
previously approved these changes
Nov 7, 2024
Thanks, makes sense. Let's do this as you suggested! |
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
dismissed stale reviews from danieljanes and chongshenng
via
02a11ff
Robert-Steiner
force-pushed
the
fix/e2e-test
branch
from
dbc51a1
to
02a11ff
Compare
danieljanes
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?