Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(framework:skip) Fix Exec API CI #4456

Merged
merged 3 commits into from
Nov 8, 2024
Merged

ci(framework:skip) Fix Exec API CI #4456

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4fb8ac
ci(framework:skip) Fix Exec API CI
chongshenng Nov 8, 2024
76b112f
Merge branch 'main' into fix-exec-ci
chongshenng Nov 8, 2024
d1e20c1
Merge branch 'main' into fix-exec-ci
chongshenng Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/test_exec_api.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ while [ "$found_success" = false ] && [ $elapsed -lt $timeout ]; do
if grep -q "Run finished" flwr_output.log; then
echo "Training worked correctly!"
found_success=true
if $3 = "deployment-engine"; then
if [ "$3" = "deployment-engine" ]; then
kill $cl1_pid; kill $cl2_pid;
fi
sleep 1; kill $sl_pid;
Expand All @@ -121,7 +121,7 @@ done

if [ "$found_success" = false ]; then
echo "Training had an issue and timed out."
if $3 = "deployment-engine"; then
if [ "$3" = "deployment-engine" ]; then
kill $cl1_pid; kill $cl2_pid;
fi
kill $sl_pid;
Expand Down