Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USFM Document import - parsing error #310

Closed
eb1 opened this issue Apr 19, 2018 · 1 comment
Closed

USFM Document import - parsing error #310

eb1 opened this issue Apr 19, 2018 · 1 comment

Comments

@eb1
Copy link
Contributor

eb1 commented Apr 19, 2018

Adapt It Mobile Version: 1.0 beta 11

Severity: 1 - data corruption

Description: I received a USFM document yesterday that reads RTL. There seems to be a parsing error in AIM such that the markers are not getting flagged as markers, and instead end up as regular source. Even the chapter breaks are not identified, which is causing the entire document to be read in as one chapter. Since AIM reads one chapter in at a time for editing, it meant that the whole file was being read in -- and everything was really slow.

I'm not sure if this condition is a general issue for our parser on RTL documents, or if it's specific to this one document. Investigating...

@eb1 eb1 added this to the Release 1.0 beta 12 milestone Apr 19, 2018
eb1 added a commit to eb1/adapt-it-mobile that referenced this issue Apr 19, 2018
Major duh error -- account for upper case file extensions
@eb1
Copy link
Contributor Author

eb1 commented Apr 19, 2018

Fixed with previous checkin:

The problem wasn't RTL scripts; instead, AIM was not checking for upper case file extensions, so the parser was loading the file as if it were plain text. With the fix, any file extension we support should be parsed correctly (regardless of the extension case).

@eb1 eb1 closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant