Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation handling inconsistent between file types #375

Closed
eb1 opened this issue Jul 5, 2019 · 1 comment
Closed

Punctuation handling inconsistent between file types #375

eb1 opened this issue Jul 5, 2019 · 1 comment
Milestone

Comments

@eb1
Copy link
Contributor

eb1 commented Jul 5, 2019

Describe the bug
Noticed this while looking at imported USFM / AI XML docs. It appears that the import and handling of punctuation is not entirely consistent between file types, and doesn't really match what AI XML does:

  • For Text, USX, and USFM files all preceding / following punctuation is removed from the source and placed in prepunct / follpunct DB fields
  • For AI XML, AIM currently pulls out the k sourcephrase field, which kind-of strips the punctuation from the source. This causes some weirdness when colon characters are encountered, for example. If imported file type was XML, the word ending with a colon is displayed with the text differences color (e.g., dark green) -- even if the words are the same in source and target.

This should be modified so that all the files types handle punctuation consistently. I would vote that the punctuation not be stripped from the source field in the database, so that the source matches the s field in the AI XML file. The handling can then be consistent in AIM's UI, to strip out the punctuation when the user sets the focus on the field.

@eb1 eb1 added this to the Release 1.2.0 milestone Jul 5, 2019
eb1 added a commit to eb1/adapt-it-mobile that referenced this issue Jul 5, 2019
Import / export of punctuation now consistent between file types. Adaptation UI updated to reflect source containing punctuation. Need to test a bit more.
@eb1
Copy link
Contributor Author

eb1 commented Sep 4, 2019

Marking issue as resolved:
Tested with Text, XML, USX, and USFM imported documents. All now are consistent in how they handle punctuation during import and adaptation.

@eb1 eb1 closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant