Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: aria-expanded attribute true/false added to navigation button (#84) #85

Merged
merged 1 commit into from
Aug 16, 2023
Merged

New: aria-expanded attribute true/false added to navigation button (#84) #85

merged 1 commit into from
Aug 16, 2023

Conversation

joe-allen-89
Copy link
Contributor

#84

New

@joe-allen-89 joe-allen-89 self-assigned this Aug 11, 2023
@joe-allen-89 joe-allen-89 linked an issue Aug 11, 2023 that may be closed by this pull request
Set aria-expanded attribute true/false to match drawer visibility #84
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 222968e into master Aug 16, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
@semantic-release-bot
Chore(release): 5.3.0 [skip ci]
244fc9e 
# [5.3.0](v5.2.4...v5.3.0) (2023-08-16)

### New

* aria-expanded attribute true/false to match drawer visibility (#85) ([222968e](222968e)), closes [#85](#85)
@github-actions
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster deleted the issue/84 branch August 16, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set aria-expanded attribute true/false to match drawer visibility
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool