Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: General cleanup (fixes #97) #98

Merged
merged 4 commits into from
May 21, 2024
Merged

Fix: General cleanup (fixes #97) #98

merged 4 commits into from
May 21, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 17, 2024 •
edited
Loading

Fix #97

Fix

  • Remove unused languagePickerNavView.js file
  • Fix typo in pull_request_template.md
  • Use shorthand for model in setupNavigationView()
  • README.md formatting fixes (e.g. line breaks, remove forward slash typos)

@swashbuck swashbuck self-assigned this May 17, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit c1dfb05 into master May 21, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/97 branch May 21, 2024 14:48
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@semantic-release-bot
Chore(release): 5.5.2 [skip ci]
340b2a3 
## [5.5.2](v5.5.1...v5.5.2) (2024-05-21)

### Fix

* General cleanup (fixes #97) (#98) ([c1dfb05](c1dfb05)), closes [#97](#97) [#98](#98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup
4 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool