Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/14-b Added playsinline #17

Merged
merged 4 commits into from
Nov 1, 2021
Merged

issue/14-b Added playsinline #17

merged 4 commits into from
Nov 1, 2021

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 30, 2021 •
edited
Loading

fixes #14

Added

  • _playsinline setting

Changed

  • Moved YouTubeView into separate file

Fixed

  • Schema booleans and defaults
  • No media src ready status

Removed

  • Whitespace

@oliverfoster oliverfoster self-assigned this Sep 30, 2021
@oliverfoster oliverfoster mentioned this pull request Sep 30, 2021
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 1, 2021
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

eleanor-heath
eleanor-heath reviewed Oct 13, 2021
View reviewed changes
js/YouTubeView.js Outdated Show resolved Hide resolved
@oliverfoster @eleanor-heath
Update js/YouTubeView.js
c48853d 
Co-authored-by: eleanor-heath <61159216+eleanor-heath@users.noreply.github.com>
@oliverfoster oliverfoster mentioned this pull request Oct 18, 2021
Closed
@oliverfoster oliverfoster merged commit 34fe958 into master Nov 1, 2021
@oliverfoster oliverfoster deleted the issue/14-b branch November 1, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chris-steele chris-steele Awaiting requested review from chris-steele

Assignees

@oliverfoster oliverfoster

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

video always plays 'inline' on iPhone
4 participants
@oliverfoster @cahirodoherty-learningpool @ethan-lp @eleanor-heath