Desktop: Fixed default migration logic

adarsh-sgh · Oct 28, 2021 · e247be1 · e247be1
1 parent 9704e75
commit e247be1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/lib/models/Setting.test.ts b/packages/lib/models/Setting.test.ts
@@ -226,6 +226,14 @@ describe('models/Setting', function() {
 		expect(Setting.value('style.editor.contentMaxWidth')).toBe(600); // Changed
 	}));
 
+	it('should skip values that are already set', (async () => {
+		await Setting.reset();
+
+		Setting.setValue('sync.target', 9);
+		Setting.applyDefaultMigrations();
+		expect(Setting.value('sync.target')).toBe(9); // Not changed
+	}));
+
 	it('should allow skipping default migrations', (async () => {
 		await Setting.reset();
 

diff --git a/packages/lib/models/Setting.ts b/packages/lib/models/Setting.ts
@@ -1457,7 +1457,7 @@ class Setting extends BaseModel {
 	}
 
 	public static isSet(key: string) {
-		return key in this.cache_;
+		return this.cache_.find(d => d.key === key);
 	}
 
 	static keyDescription(key: string, appType: AppType = null) {