Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete confirmation popup should show always #306

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Delete confirmation popup should show always #306

merged 2 commits into from
Oct 21, 2021

Conversation

ikrysteq
Copy link
Contributor

Delete confirmation popup should show always when user clicks a "Delete" option.
Many colleagues trying to click "Debug war package" by accident select the "Delete" option and this deletes the server and all config defined there.

@ikrysteq ikrysteq changed the title Delete confirmation popup should be always Delete confirmation popup should show always Jul 14, 2020
Eskibear
Eskibear approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Althrough I'm not a heavy user of Tomcat, this behavior change makes sense to me.

@Eskibear Eskibear mentioned this pull request Oct 15, 2021
Closed
@Eskibear Eskibear merged commit 69e33b7 into adashen:develop Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear Eskibear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikrysteq @Eskibear