Do not allow dropping text on the columns #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Oct 2, 2023
| @@ -201,7 +206,7 @@ export default function HeaderCell<R, SR>({ | |||
| } | |||
|
|
|||
| function onDragStart(event: React.DragEvent<HTMLDivElement>) { | |||
| event.dataTransfer.setData('text/plain', column.key); | |||
| event.dataTransfer.setData(dragDropKey, column.key); | |||
There was a problem hiding this comment.
amanmahajan7
commented
Oct 2, 2023
src/HeaderCell.tsx
Outdated
| @@ -51,6 +53,8 @@ const cellOver = css` | |||
|
|
|||
| const cellOverClassname = `rdg-cell-drag-over ${cellOver}`; | |||
|
|
|||
| const dragDropKey = 'column-key'; | |||
There was a problem hiding this comment.
We should probably make this unique for each grid instance
There was a problem hiding this comment.
Using useId to generate uniqueKey for each grid
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
=======================================
Coverage ? 82.98%
=======================================
Files ? 47
Lines ? 5071
Branches ? 789
=======================================
Hits ? 4208
Misses ? 863
Partials ? 0
|
amanmahajan7
commented
Oct 2, 2023
Comment on lines
+226
to
+227
| if (event.dataTransfer.types.includes(dragDropKey)) { | ||
| const sourceKey = event.dataTransfer.getData(dragDropKey); |
There was a problem hiding this comment.
I can probably add an undefined check instead but need to ignore the types
nstepien
approved these changes
Oct 2, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Do not allow dropping text on the columns * Fix test * Use `useId` to generate unique key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3349