bug: name collision in isCellEditable breaks edit feature #3356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Under certain conditions when bundled, two identically named functions (
isCellEditable
) can clash.How to replicate
next@13.5.4
or laternpm run dev
shows expected functionality of cell becoming editable after double click or carriage returnnpm run build && npm run start
shows an unexpected outcome, cell edit becomes unreachable in productionGoing through the compiled code with some strategic logging shows that the production build version of the code prefers the utility
isCellEditable
rather than the function insideDataGrid
. As they accept two different arguments sets, this breaks the edit feature.Fix
Renaming the utility to
isCellEditableUtil
resolves this issue. If this name isn't preferred, I am open to suggestion and happy to change it.