Fix undefined error due to columnIdx out of bounds
#3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3372 +/- ##
==========================================
+ Coverage 83.15% 83.17% +0.02%
==========================================
Files 47 47
Lines 5092 5100 +8
Branches 795 796 +1
==========================================
+ Hits 4234 4242 +8
Misses 858 858
|
nstepien
previously approved these changes
Oct 20, 2023
src/DataGrid.tsx
Outdated
| @@ -690,6 +690,7 @@ function DataGrid<R, SR, K extends Key>( | |||
| function isCellEditable(position: Position): boolean { | |||
| return ( | |||
| isCellWithinViewportBounds(position) && | |||
| position.idx !== -1 && | |||
There was a problem hiding this comment.
isCellWithinViewportBounds doesn't catch this? 🤔
Should we add a test?
There was a problem hiding this comment.
It uses https://github.com/adazzle/react-data-grid/blob/main/src/DataGrid.tsx#L674 and minColIdx === -1
There was a problem hiding this comment.
May be we need to add a new function withinEditBounds
There was a problem hiding this comment.
Not sure how to test it. I will check
nstepien
approved these changes
Oct 20, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Check columnIdx is within bounds * Add helper * Inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3369