-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reflect new file layout of .geom files in near_field #259
Conversation
The fix is good. Thanks! The extra line in geometry files appeared due to recent incorporation of rectangular dipoles. |
Ok, I force-updated my fix. Do you mean |
Timo, sorry for the delay. I have been at the conference previous week. I have tested your fix, and it works fine. However, I want to take this opportunity and fix a couple of related issues in near_field and combine it into this pull request. This may take a couple more days. |
- changed processing of shape file (target) in gendip.f not to depend on precise number of commented lines. Now it also works fine for multi-domain shape files. - updated tests, mainly due to recent ability of ADDA to use odd grids: 1) added '-grid 20' in sop to be able to compare with previous references; 2) changed references in box11 (alternatively '-grid 12' was tested as a viable fix). - added a new test coated to test multi-domain shapes (it is incompatible with undocumented debug level 2). - removed -ffast_math from compilation flags (caused some weird warnings).
Timo, I have fixed everything I wanted and pushed it to your branch (so it automatically updated this pull request). Can you please test the current state - both compiling and |
I've rerun tests and they still work. As an aside, I'm on OS X with GNU Fortran from Homebrew (GCC 8.2.0) and to get things to compile, I had to
|
Oh, and a more important remark, you added |
- added comments to Makefile - added executable flags to RUNTESTS/coated/clean,run
Description
misc/near_field/gendip.f
seems to read.geom
files incorrectly. Corrected and tested on./runexample
Related issues
Fixes #... or Related to #...
Types of changes
Checklist
Further comments