Skip to content

Commit

Permalink
src: remove unused perf_hooks uv handles
Browse files Browse the repository at this point in the history
A couple of unused uv handles were accidentally left
in env.

PR-URL: nodejs/node#15368
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
jasnell authored and addaleax committed Sep 17, 2017
1 parent 85ded3f commit 4c11362
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 38 deletions.
27 changes: 0 additions & 27 deletions src/env-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -529,33 +529,6 @@ inline std::map<std::string, uint64_t>* Environment::performance_marks() {
return &performance_marks_;
}

inline Environment* Environment::from_performance_check_handle(
uv_check_t* handle) {
return ContainerOf(&Environment::performance_check_handle_, handle);
}

inline Environment* Environment::from_performance_idle_handle(
uv_idle_t* handle) {
return ContainerOf(&Environment::performance_idle_handle_, handle);
}

inline Environment* Environment::from_performance_prepare_handle(
uv_prepare_t* handle) {
return ContainerOf(&Environment::performance_prepare_handle_, handle);
}

inline uv_check_t* Environment::performance_check_handle() {
return &performance_check_handle_;
}

inline uv_idle_t* Environment::performance_idle_handle() {
return &performance_idle_handle_;
}

inline uv_prepare_t* Environment::performance_prepare_handle() {
return &performance_prepare_handle_;
}

inline IsolateData* Environment::isolate_data() const {
return isolate_data_;
}
Expand Down
11 changes: 0 additions & 11 deletions src/env.h
Original file line number Diff line number Diff line change
Expand Up @@ -617,14 +617,6 @@ class Environment {
inline performance::performance_state* performance_state();
inline std::map<std::string, uint64_t>* performance_marks();

static inline Environment* from_performance_check_handle(uv_check_t* handle);
static inline Environment* from_performance_idle_handle(uv_idle_t* handle);
static inline Environment* from_performance_prepare_handle(
uv_prepare_t* handle);
inline uv_check_t* performance_check_handle();
inline uv_idle_t* performance_idle_handle();
inline uv_prepare_t* performance_prepare_handle();

inline void ThrowError(const char* errmsg);
inline void ThrowTypeError(const char* errmsg);
inline void ThrowRangeError(const char* errmsg);
Expand Down Expand Up @@ -704,9 +696,6 @@ class Environment {
uv_timer_t destroy_ids_timer_handle_;
uv_prepare_t idle_prepare_handle_;
uv_check_t idle_check_handle_;
uv_prepare_t performance_prepare_handle_;
uv_check_t performance_check_handle_;
uv_idle_t performance_idle_handle_;

AsyncHooks async_hooks_;
DomainFlag domain_flag_;
Expand Down

0 comments on commit 4c11362

Please sign in to comment.