Skip to content

Commit

Permalink
test: fix flaky test-vm-timeout
Browse files Browse the repository at this point in the history
Likely fix the flaky parallel/test-vm-timeout. Increase the outer
timeout in the test checking for nested timeouts with `vm` scripts
so that its firing won’t interfere with the inner timeout.

Fixes: nodejs#6727
PR-URL: nodejs#7373
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
addaleax committed Jul 12, 2016
1 parent 110ce55 commit d5ce440
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-vm-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ assert.throws(function() {
vm.runInNewContext('while(true) {}', context, { timeout: timeout });
}
};
vm.runInNewContext('runInVM(10)', context, { timeout: 100 });
vm.runInNewContext('runInVM(10)', context, { timeout: 10000 });
throw new Error('Test 5 failed');
}, /Script execution timed out./);

0 comments on commit d5ce440

Please sign in to comment.