Improve logic around cancelling consumers and closing models. #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of fixes in here, which are separated out into separate commits, specifically:
Wait
but attempting to do so unearths a limitation of theFakeConnectionFactory
that breaks theExchangeHeadersTests
andExchangeFanoutTests
because they use two connections. This is something I'd like to look into more in the future but I don't have time right now.Apologies for the several disparate changes in a single MR, I kept going until my code under test passed tests following the upgrade to
2.3.0
. Hopefully the fact that it's in different commits allows for easy review, but if you'd like me to split it into separate MRs, please do let me know (and thanks for all your time reviewing my MRs recently, @odalet !)