Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocking/synchronous delivery to consumers #123

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

patrikwlund
Copy link

It simplifies some testing scenarios because you don't need infrastructure and boilerplate for message waits.

Note that this does nothing regarding the ack/nack flow, it just allows us to make the initial publish/delivery operation blocking.

It simplifies some testing scenarios because you don't need infrastructure and boilerplate for message waits.
@odalet odalet changed the base branch from master to temp December 14, 2022 16:15
@odalet odalet merged commit 241d004 into addupsolutions:temp Dec 14, 2022
@odalet
Copy link

odalet commented Dec 14, 2022

Hi, once a gain a cool addition. I modified a bit your code with mostly cosmetic changes (well renamed a few things too).
I also made the new property of RabbitServer read-only (and hence, defined from the constructor). I feel it's a bit cleaner as once set, this should not change later.

Nuget coming soon

@patrikwlund patrikwlund deleted the blocking-consumer-delivery branch December 14, 2022 19:19
@patrikwlund
Copy link
Author

I modified a bit your code

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants