Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gradle): Simpler Kotlin DSL Property Assignment #784

Merged
merged 3 commits into from
Jun 24, 2024
Merged

chore(gradle): Simpler Kotlin DSL Property Assignment #784

merged 3 commits into from
Jun 24, 2024

Conversation

SimonMarquis
Copy link
Member

Following #782

soulcramer
soulcramer previously approved these changes Oct 17, 2023
View reviewed changes
@SimonMarquis SimonMarquis disabled auto-merge October 17, 2023 09:35
kazaky
kazaky previously approved these changes Nov 10, 2023
View reviewed changes
@SimonMarquis SimonMarquis marked this pull request as draft January 26, 2024 10:08
@SimonMarquis SimonMarquis force-pushed the kotlin-dsl-assignment-2 branch from b2c5dae to 56c1104 Compare February 2, 2024 19:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.6 ✅ Build Scan NOT_PUBLISHED
spark-android spotlessCheck :build-logic:spotlessCheck 8.6 ❌ Build Scan NOT_PUBLISHED

@SimonMarquis
Copy link
Member Author

@spark-ui-bot spotless

@SimonMarquis
Copy link
Member Author

Let's wait for pinterest/ktlint#2382

@SimonMarquis SimonMarquis dismissed stale reviews from soulcramer and kazaky via 9ca3725 June 24, 2024 09:05
@SimonMarquis SimonMarquis force-pushed the kotlin-dsl-assignment-2 branch from 56c1104 to 9ca3725 Compare June 24, 2024 09:05
@SimonMarquis SimonMarquis marked this pull request as ready for review June 24, 2024 09:05
@SimonMarquis SimonMarquis enabled auto-merge June 24, 2024 09:26
@SimonMarquis
Copy link
Member Author

@soulcramer this PR is ready to be reviewed :)

soulcramer
soulcramer approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@soulcramer soulcramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goot to me!

@SimonMarquis SimonMarquis added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 61d7d8e Jun 24, 2024
6 checks passed
@SimonMarquis SimonMarquis deleted the kotlin-dsl-assignment-2 branch June 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulcramer soulcramer soulcramer approved these changes

@kazaky kazaky kazaky left review comments

Assignees

@SimonMarquis SimonMarquis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonMarquis @kazaky @soulcramer