[Button] Refactoring

[robergro]

• Rename Text to title to have same property as a native UIButton (PR)
• Inherite from UIControl and not UIView (PR)
• Add title and attributedTitle for state (get and set func) (PR)
• Split the Button to have a IconButton (PR)
• Update snapshot testing (PR)
• Update Wiki

[elisa-hery]

Test branch : refacto/button/all

[elisa-hery]

ℹ️ what changed ?

• now the content can be updated according to the state (eg : a content for default state, a different one for selected state)
• we now have a isSelected state

[elisa-hery]

@robergro here are 2 questions about button :

• question : what happens if a text is too big for the button ? Is there an ellipsis in the middle of the text, like for a large dynamic types ? We need to check if design is ok with that

- a11y : contrary to iconButton, voice over recognize the component but does not identify it as a button, and I think it's not normal. `Traits` should not be defined as "static text", WDYT ?

[elisa-hery]

@robergro questions about iconButton :

• about small size : according to the specs, touch area should be 44px and it's not.

Enregistrement.de.l.ecran.2024-01-19.a.12.08.00.mov

• Also, i'm not sure if we should have small square iconButtons (but it's no big deal)

• accessibility : voice over canot read this button even when it's enabled, I think it's a problem

Enregistrement.de.l.ecran.2024-01-19.a.12.59.35.mov

• please note that functionality is hard to test because demo app is not so close from real behavior of iconButton. It would be great to have a beta-tester Polaris team, to see how it works in real conditions

[robergro]

• question : what happens if a text is too big for the button ? Is there an ellipsis in the middle of the text, like for a large dynamic types ? We need to check if design is ok with that
  We don’t have other option, if the available space is not big enough, the text is truncated … 
It is the same thing for all component with a static height

• a11y : contrary to iconButton, voice over recognize the component but does not identify it as a button, and I think it's not normal. Traits should not be defined as "static text", WDYT ?
  I fixed it, the consumer need to set a property to have the expected content when voice over is enabled. On the demo I setted a value ("My icon button")

• about small size : according to the specs, touch area should be 44px and it's not.
  The size is 32px and on iOS, it is a very bad practice to update the size of the tapeable area (here ton 44px), we already informed all the team about this choice/decision.

• Also, i'm not sure if we should have small square iconButtons (but it's no big deal)
  Agree with that, but I think we can change this rule later, the UI/UX should just be careful if they really want to use this size…

• accessibility : voice over canot read this button even when it's enabled, I think it's a problem
  You’re right. It should be ok now ! I added a property on the demo app to switch between the default value and the value which can be set by the consumer (if he want to have an another value)

• please note that functionality is hard to test because demo app is not so close from real behavior of iconButton. It would be great to have a beta-tester Polaris team, to see how it works in real conditions
  Yes you’re right ! I added

  • on UIKit, on the controlType configuration line a new entry: toggle. With this entry, you can now check a toggle action
  • on SwiftUI a checkbox to activated the toggle mode

[elisa-hery]

• A11y is now fixed

• the rest is ok ✅

--> ready for design review !
new branch is : refacto/button/fix

[elisa-hery]

Approved by @JeremiasUX ✅ (see slack thread here). I'm moving it to RFP !